A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I don't think we should be running mypy on Tools/peg_generator/ on the 3.12 branch. It has a mypy.ini file on the 3.12 branch, it's true, but as you can see, mypy doesn't pass for that directory on the 3.12 branch. It only started passing on this directory after certain changes that we made to the main branch (that aren't worth backporting to 3.12).

I'd prefer it if you only changed this line in the mypy.yml file, and left the others as they are :)

I don't think we should be running mypy on Tools/peg_generator/ on the 3.12 branch. It has a mypy.ini file on the 3.12 branch, it's true, but as you can see, mypy doesn't pass for that directory on the 3.12 branch. It only started passing on this directory after certain changes that we made to the main branch (that aren't worth backporting to 3.12).

I'd prefer it if you only changed this line in the mypy.yml file, and left the others as they are :)

cpython/.github/workflows/mypy.yml

Line 38 in 5c4f9a1

- run: pip install -r Tools/clinic/requirements-dev.txt

Yeah, I already saw that I did it for nothing :)

Thanks!

No problem! Can I also ask, do you have a small easy issue related to python code in any repository?

Thanks!

No problem! Can I also ask, do you have a small easy issue related to python code in any repository?

Hmm, not sure :/ You could try looking through the issues with the easy label on the CPython tracker? :)

There's also some docs ones at #110383

And “easy”, “good first issue” and “help wanted” issues in other Python core repos:

• https://github.com/search?q=org%3Apython+-repo%3Apython%2Fcpython+is%3Aissue+is%3Aopen+label%3Aeasy%2C%22good+first+issue%22%2C%22help+wanted%22&type=issues&ref=advsearch

Thank you so much!)